commit 45e3694fc8e91642cf970bd1586bd1a16dbc8a31
parent 5c936efc427f2d326dab3f8d22cb34159b8292b2
Author: Guido Cella <guido@guidocella.xyz>
Date: Sun, 28 Jan 2024 09:01:09 +0100
remove useless wlr_scene_node_reparent() calls
These don't do anything because wlr_scene_node_reparent() is immediately
called again by setfloating() through setmon(). They are also a source
of confusion because if you change the wlr_scene_node_reparent() call in
applyrules() it takes a while to understand why it doesn't work.
Diffstat:
1 file changed, 0 insertions(+), 2 deletions(-)
diff --git a/dwl.c b/dwl.c
@@ -453,7 +453,6 @@ applyrules(Client *c)
}
}
}
- wlr_scene_node_reparent(&c->scene->node, layers[c->isfloating ? LyrFloat : LyrTile]);
setmon(c, mon, newtags);
}
@@ -1546,7 +1545,6 @@ mapnotify(struct wl_listener *listener, void *data)
/* TODO: https://github.com/djpohly/dwl/pull/334#issuecomment-1330166324 */
if (c->type == XDGShell && (p = client_get_parent(c))) {
c->isfloating = 1;
- wlr_scene_node_reparent(&c->scene->node, layers[LyrFloat]);
setmon(c, p->mon, p->tags);
} else {
applyrules(c);